ModelSignal.connect() does not work when 'weak' is set to False and receiver is a local function

[laevilgenius]

Since #26642 there seems to be a regression. ModelSignal.connect doesn't take into account 'weak' argument.

Quick fix might look like this:

django/db/models/signals.py

@@ -27 +27 @@
             return partial_method(sender)
 
     def connect(self, receiver, sender=None, weak=True, dispatch_uid=None, apps=None):
-        self._lazy_method(super(ModelSignal, self).connect, apps, receiver, sender, dispatch_uid=dispatch_uid)
+        self._lazy_method(super(ModelSignal, self).connect, apps, receiver, sender, weak=weak, dispatch_uid=dispatch_uid)
 
     def disconnect(self, receiver=None, sender=None, weak=None, dispatch_uid=None, apps=None):
         if weak is not None:

[Tim Graham]

​PR

[GitHub <noreply@…>]

In 9bf8d50a:

Fixed #26778 -- Fixed ModelSignal.connect() weak argument.

[Tim Graham <timograham@…>]

In 91d754e:

[1.10.x] Fixed #26778 -- Fixed ModelSignal.connect() weak argument.

Backport of 9bf8d50a678463a5a3cd52f10c830fe0ca65d2c6 from master