Context Navigation

← Previous Ticket
Next Ticket →

#26474 closed Cleanup/optimization (fixed)

Add source of minified javascript files

Reported by:	Raphaël Hertzog	Owned by:	Pyie Zone
Component:	Packaging	Version:	1.9
Severity:	Normal	Keywords:
Cc:		Triage Stage:	Accepted
Has patch:	no	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	no
Easy pickings:	no	UI/UX:	no

Description

In Debian, we like to have the sources of everything that we ship and we consider that minified javascript files are not really scripts (which are their own source).

There are currently two problematic files in Django:
js_tests/qunit/blanket.min.js
django/contrib/admin/static/admin/js/vendor/xregexp/xregexp.min.js

To remedy this I would suggest to either:

directly use a non-minified file like you do for many other javascript files (ex: django/contrib/admin/static/admin/js/SelectFilter2.js)
store a non-minified file next to the minified file (same name without the ".min" part)

Thank you for considering this request.

Change History (11)

comment:1 by Tim Graham, 9 years ago

I've asked for thoughts about this on the django-developers mailing list.

comment:2 by Tim Graham, 9 years ago

Component:	Uncategorized → Packaging
Triage Stage:	Unreviewed → Accepted

We can add the non-minified versions I guess. This would also include modifying django/contrib/admin/options.py to use extra in vendor/xregexp/xregexp.min.js.

comment:3 by Pyie Zone, 9 years ago

Owner:	changed from nobody to Pyie Zone
Status:	new → assigned

comment:4 by Pyie Zone, 9 years ago

I've created PR 6724

The added source file xregexp.js did not pass js check. It was downloaded directly from the original repo. I am not familiar with the process. Am I supposed to update the source js file to make it pass? Thanks!