Fix admin formatting when help_text used with multiple fields on the same line

[Andy Dustman <farcepest@…>]

If you have a case where you have set multiple fields to appear on the same line in the admin interface, the current version produces a line break when help_text is present, due to it being in a <p> element. To fix it in a half-assed sort of way, I wrapped the entire field in a <div style="float: left">. The diff is should below:

Index: django/contrib/admin/templates/admin/field_line.html
===================================================================
--- django/contrib/admin/templates/admin/field_line.html        (revision 3669)
+++ django/contrib/admin/templates/admin/field_line.html        (working copy)
@@ -2,9 +2,11 @@
 <div class="{{ class_names }}" >
 {% for bound_field in bound_fields %}{{ bound_field.html_error_list }}{% endfor %}
 {% for bound_field in bound_fields %}
+ <div style="float: left;">
   {% if bound_field.has_label_first %}{% field_label bound_field %}{% endif %}
   {% field_widget bound_field %}
   {% if not bound_field.has_label_first %}{% field_label bound_field %}{% endif %}
   {% if bound_field.field.help_text %}<p class="help">{{ bound_field.field.help_text }}</p>{% endif %}
+ </div>
 {% endfor %}
 </div>

Ultimately you want a class which does this, which means changing the admin stylesheet, so you probably don't want to use this patch exactly.

The patch does not appear to affect the default case of stacked fields, as the the field line itself is wrapped in another <div>.

[Andy Dustman <farcepest@…>]

Proper patch for the fix. Adds a form-row-item class and applies it with a div around every bound_field

[Chris Beaven]

I can confirm this patch fixes the above problem. I would upload before / after screenshots but trac won't let me.

Probably needs some more testing to make sure this doesn't break any existing fields.

[hakejam]

Expanded on the idea above using the float-left css class that was already in the admin. I have tested it with a few examples, but still needs more testing. Not sure if this applies to the newforms-admin branch.

[Simon G. <dev@…>]

It's not closed until it's checked in

[Gary Wilson]

This needs to be fixed in newforms-admin, as it will soon will be replacing the current admin.

[xian]

Assigning to myself to make sure it gets attended to in newforms-admin. We're allowing stacked inlines to take full fieldsets so we have a there will be edge cases there to work out.

[Karen Tracey <kmtracey@…>]

Formatting improvement for a problem that was noted in old admin, should not block newforms-admin merge.

[Brian Rosner]

updated to r8388

[Brian Rosner]

I attached a patch that applies on the latest trunk (r8388). I am not a UI designer nor really that great with front-end work. However, this does fix the problem of the line break, but doesn't seem 100% ideal. Also if there is no help_text on the first field in a two field grouping, but help_text on the second one, then the latter's help_text is placed under the first. Ideally someone with better skills in this area is required. :)

[Brian Rosner]

Closed #7054 as a duplicate. The patch there provides a fix to the problem I described in my last comment.

[Manuel Saelices]

I've tried to test this ticket, but I've not found right admin options for placing two fields in same line. I've been trying with this, but I didn't find the correct CSS class for placing into same line:

# model:
class Person(models.Model):
    name = models.CharField(max_length=128, help_text="Please input the name")
    date_joined = models.DateTimeField()

# admin:
class PersonAdmin(admin.ModelAdmin):
    fieldsets = (('Avanced options', {'classes': '????????', # what CSS class?
                                      'fields': ('person', 'date_joined')}),)

What CSS class we use? Is correct this approach to reproduce UI bug?

[Manuel Saelices]

Sorry for previous comment, correct last line was:

'fields': ('name', 'date_joined')}),)

[Malcolm Tredinnick]

@msaelices: don't worry about testing this. Jacob and I sat down with a designer (Nathan Borror) last week and discussed this. He's going to look at some solutions that will work. We'll use whatever he comes up with. (By the way, the feature you were looking for is fieldsets and then tuples of fields).

[Manuel Saelices]

@mtredinnick, ok. I'll wait :-P, but, I think fieldsets is just I put in my PersonAdmin options, isn't?

[Brian Rosner]

(In [8824]) Fixed #2612 -- Fixed admin formatting when help_text is used with multiple fields on the same line.

[nathan]

This one's better

[nathan]

Admin inline float fix

[Alex Gaynor]

Reopening since we now have a patch from nathan, a real designer :P

[Jannis Leidel]

With all due respect patching a global CSS class like .float-left seems unreasonable, creating an own class should also work.

Also, please fix it for rtl-languages.

[Jannis Leidel]

Fix that doesn't patch float-left class and is rtl compatible.

[Jacob]

Fixed in [8871].

[Jacob]

Milestone 1.0 deleted