"domain" in sites framework should clarify if it is a fully-qualified domain name

[mandm]

The documents on sites framework should clarify that the ​domain should be a "fully qualified domain name" or just the "domain name".

An example where things can be confusing:

I have a setup where all requests to non-www domain i.e. http://example.com are redirected (with status 301) to http://www.example.com by the webserver. Hence I've set my preferred site in google webmasters tool as www.example.com (as opposed to example.com). When I use the sitemap framework, the urls generated are http://example.com/abc which is incorrect in my case. This makes me think that the domain in sites framework should have been www.example.com (instead of example.com). This is not evident from the documentation.

[Tim Graham]

Yes, I believe it should be fully-qualified. On djangoproject.com, for example, we have the domains docs.djangoproject.com and www.djangoproject.com.

[bipsandbytes]

Fixed in ​https://github.com/bipsandbytes/django/tree/ticket_24983

[bipsandbytes]

Pull request here: ​https://github.com/django/django/pull/4903

[Tim Graham <timograham@…>]

In 34047b2:

Fixed #24983 -- Clarified contrib.sites Site.domain is fully qualified.

[Tim Graham <timograham@…>]

In 6aa618ba:

[1.8.x] Fixed #24983 -- Clarified contrib.sites Site.domain is fully qualified.

Backport of 34047b23e284fd3459903294a5776b67c3e33ed9 from master