Opened 10 years ago

Closed 9 years ago

#24935 closed Cleanup/optimization (fixed)

refactor conditional GET handling

Reported by: Denis Cornehl Owned by: Denis Cornehl
Component: HTTP handling Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Django has currently three different places where conditional GET is handled

  • ConditionalGetMiddleware
  • @condition (and so @etag and last_modified) decorators
  • CommonMiddleware

they all do it differently.

I want to refactor this into the same shared behavior.

This is a starting point to fix some related tickets and (most likely) deprecate and remove settings.USE_ETAGS

Change History (4)

comment:1 by Denis Cornehl, 10 years ago

Has patch: set
Owner: changed from nobody to Denis Cornehl
Status: new → assigned

comment:2 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Tim Graham, 9 years ago

Patch needs improvement: set

Feedback left on ​the pull request.

comment:4 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 7a40fef:

Fixed #24935 -- Refactored common conditional GET handling.

Note: See TracTickets for help on using tickets.
Back to Top