Opened 10 years ago

Closed 3 years ago

#24125 closed Bug (wontfix)

TemplateDetailView in admindocs requires a single Django templates engine

Reported by: Aymeric Augustin Owned by: Kai Richard König
Component: contrib.admindocs Version: dev
Severity: Normal Keywords: multiple-template-engines
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

TemplateDetailView.get_context_data() calls Engine.get_default() which raises ImproperlyConfigured if zero or several Django templates engines are configured.

This limitation should either be lifted or documented. Gracefully showing an error message would already be better than failing with an uncaught exception.

Change History (10)

comment:1 by Aymeric Augustin <aymeric.augustin@…>, 10 years ago

In 511a53b3142551a1bc3093ed1b6655f57634f510:

Avoided exceptions in admindocs' template detail view.

This is marginally better than crashing when several Django template
engines are configured in a project.

Refs #24125.

comment:2 by Tim Graham, 10 years ago

Keywords: 1.8 added
Severity: Release blocker → Normal
Triage Stage: Unreviewed → Accepted

This view seems pretty obscure and of limited use. I'm going to demote from a release blocker and tag it "1.8" instead so we make sure to document the limitation if no one cares to write a patch by then.

comment:3 by Aymeric Augustin, 10 years ago

Yes, since it doesn't crash anymore, it isn't a blocker.

comment:4 by Tim Graham, 10 years ago

Keywords: 1.8 removed

I don't think so many people will hit this issue that it's even worth documenting.

comment:5 by Aymeric Augustin, 10 years ago

Fine.

comment:6 by Kai Richard König, 10 years ago

Owner: changed from nobody to Kai Richard König
Status: new → assigned

comment:7 by Aymeric Augustin, 10 years ago

As duplicate ticket #24957 shows, at least one person has noticed.

comment:8 by Tim Graham, 10 years ago

It was the person working on this ticket who didn't realize the purpose of it.

comment:9 by Tim Graham <timograham@…>, 10 years ago

In 3c593ba7:

Refs #24125 -- Added admin_docs tests for multiple template engines.

This adds a test for 511a53b3142551a1bc3093ed1b6655f57634f510

in reply to:  4 comment:10 by Mariusz Felisiak, 3 years ago

Resolution: → wontfix
Status: assigned → closed

Replying to Tim Graham:

I don't think so many people will hit this issue that it's even worth documenting.

I agree with Tim.

Note: See TracTickets for help on using tickets.
Back to Top