Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#23097 closed Bug (fixed)

Documentation on FILE_UPLOAD_PERMISSIONS uses deprecated octal notation

Reported by: jmv_deb@… Owned by: David Hoffman
Component: Documentation Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Hello

Thank you for django.

In ​https://docs.djangoproject.com/en/1.6/topics/http/file-uploads/#changing-upload-handler-behavior
and ​https://docs.djangoproject.com/en/1.6/ref/settings/#std:setting-FILE_UPLOAD_PERMISSIONS

One is suggested to use octal notation like 0644. This doesn't work with python3 (tried 3.4.1) and the correct notation now is 0o644. That notation also works in python 2.7.

Cheers

Change History (9)

comment:1 by Tim Graham, 10 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug

Indeed, Django's own tests use the notation you mentioned.

comment:2 by David Hoffman, 10 years ago

Owner: changed from nobody to David Hoffman
Status: new → assigned

comment:3 by David Hoffman, 10 years ago

I have completed this and made a pull request (​https://github.com/django/django/pull/2962).

I found a few other places in the docs with the same problem, so I fixed those as well.

comment:4 by Claude Paroz <claude@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In e1c85167a3de7adf51105d5f0751b39fa0d49ba7:

Fixed #23097 -- Switched to new octal format in docs

comment:5 by Claude Paroz <claude@…>, 10 years ago

In 08e8e2137db9381d473f6c5b6b1d4240c47b7414:

[1.7.x] Fixed #23097 -- Switched to new octal format in docs

Backport of e1c85167a3 from master.

comment:6 by Claude Paroz <claude@…>, 10 years ago

In 2630cafc86bf6cc86ec8b47f0074b42f45b1f944:

[1.6.x] Fixed #23097 -- Switched to new octal format in docs

Backport of e1c85167a3 from master.

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In f24b5926:

Refs #23097 -- Used new octal format in FILE_UPLOAD_PERMISSIONS docs.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In ccf3cecb:

[3.1.x] Refs #23097 -- Used new octal format in FILE_UPLOAD_PERMISSIONS docs.

Backport of f24b59267be2e5fc5bd1252efda3aed19f860813 from master

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In f175e03:

[3.0.x] Refs #23097 -- Used new octal format in FILE_UPLOAD_PERMISSIONS docs.

Backport of f24b59267be2e5fc5bd1252efda3aed19f860813 from master

Note: See TracTickets for help on using tickets.
Back to Top