Allow PasswordResetForm email to render URLs based on the current namespace

[Ben Davis]

I have multiple namespace instances for password reset urls. The email template rendered by the default PasswordResetForm does not included a current_app context. It's an easy fix, though, ass the PasswordResetForm already has self.current_app. Just need to wrap the context instance passed to the email template:

django/contrib/auth/forms.py

@@ -4 +4 @@
 
 from django import forms
 from django.forms.utils import flatatt
-from django.template import loader
+from django.template import loader, Context
 from django.utils.encoding import force_bytes
 from django.utils.html import format_html, format_html_join
 from django.utils.http import urlsafe_base64_encode
@@ -264 +264 @@
                 'token': token_generator.make_token(user),
                 'protocol': 'https' if use_https else 'http',
             }
-            subject = loader.render_to_string(subject_template_name, c)
+            context_instance = Context(current_app=self.current_app)
+            subject = loader.render_to_string(
+                subject_template_name, c, context_instance)
             # Email subject *must not* contain newlines
             subject = ''.join(subject.splitlines())
-            email = loader.render_to_string(email_template_name, c)
+            email = loader.render_to_string(
+                email_template_name, c, context_instance)
 
             if html_email_template_name:
                 html_email = loader.render_to_string(html_email_template_name, c)

[Ben Davis]

Correction, PasswordResetForm does not have current_app built in. That needs to be added as well.

[Baptiste Mispelon]

Hi,

I agree that it would be good to have the current app while rendering the body of the email because it would help with reversing URLs inside it.
However, I don't really understand the use-case behind having the current app when rendering the subject line.

In any case, the provided patch doesn't apply on master and it's also going to require tests and documentation.

Thanks.

[Ben Davis]

@bmispelon, I think one would expect the context to be identical in both the body and the subject. Whether or not there's a use case, I can't think of any justification for making them separate. I plan on working on this (as well as various other tickets I've submitted) once I get a little more free time.

[Tim Graham]

current_app is no longer an argument to render_to_string() but I think this would be resolved by passing request instead (which can be passed to send_mail() from save()). The url template tag uses the namespace of the currently resolved view as the current application in a RequestContext.