Consider not using built-in functions as parameters

[no]

Currently the staticfiles finders' find function has a parameter all which is also a built-in function. Personally, I consider using built-ins as parameters/variables to be bad form, and would usually just rename the parameter in my subclasses. Unfortunately, find is explicitly called with all=all in django.contrib.staticfiles.finders.find(). So, to use the built in all() one needs to use from __builtin__ import all as all_.

There are probably more examples throughout the codebase, but this is the one I've run into.

[Tim Graham]

Unfortunately, I think changing this is not going to be worth it, backwards compatibility wise. Will leave it open for a second opinion though.

[no]

Couldn't the arguments undergo the normal django deprecation cycle? For two version accept both, but issue a warning if the builtin version is used.

[Aymeric Augustin]

The all kwarg is a private API, so we can change it. However, we should check whether this is going to break popular third-party addons. (I don't know the staticfiles landscape very well.)

[Andreu Vallbona]

I think I can work on this ticket. I've created a draft pull request ​PR Let me know what do you think about it.

[nessita <124304+nessita@…>]

In 0fdcf102:

Fixed #22712 -- Avoided name shadowing of "all" in django.contrib.staticfiles.finders.

Co-authored-by: Natalia <124304+nessita@…>

[Natalia Bidart]

In 8719a618:

Refs #22712 -- Corrected deprecation of "all" argument in django.contrib.staticfiles.finders.find().

Features deprecated in Django 5.2 should be removed in Django 6.1.

[nessita <124304+nessita@…>]

In 6bd5d4f:

Refs #22712 -- Adjusted deprecation warning stacklevel in staticfiles finders.