Generic Views should have user_passes_test=func argument

[django@…]

django.views.generic.create_update.*_object Generic Views allow for the argument 'login_required=True' which behaves just like the auth decorator of the same name.

Many times just being logged in is not enough, but certain permissions are required for a view (reporter vs. editor vs. reviewer etc.)
Currently you need to write a custom generic view to get the auth user_passes_test decorator functionality.

It would greatly simplify things if the generic views accepted a 'user_passes_test=func' argument.

[Adrian Holovaty]

You can wrap the generic view like so:

def my_view(request, *args, **kwargs):
    if not request.user.has_perm('foo'):
        return HttpResponseRedirect('/login/')
    return create_update(request, *args, **kwargs)

[anonymous]

I understand that it can be wrapped easilly, you can also do:

@login_required
def my_view(request, *args, **kwargs):
    return create_update(request, *args, **kwargs)

But there is a login_required shortcut directly on the generic views. Just thought it would be a good addition.