Default geom_type attribute for GeometryWidget should be "Geometry", not "Unknown"

[Mathieu Leplatre]

The default value for geom_type is "Unknown" whereas we expect it to be "Geometry".

Indeed, by default we rely on GDAL to set the geom_type attribute, and it returns an unexpected value :

>>> from django.contrib.gis import gdal
>>> str(gdal.OGRGeomType('GEOMETRY'))
'Unknown'

In fields, we override explicitly his value, so the problem is hidden.
​https://github.com/django/django/blob/1.6b2/django/contrib/gis/forms/fields.py#L42

But IMHO the widget should behave nicely with default values, for example instantiated like this :

class BigMapWidget(BaseGeometryWidget):
    map_height = 1200


class GeomForm(forms.Form):

    def __init__(self, *args, **kwargs):
         super(GeomForm, self).__init__(*args, **kwargs)
         self.fields['geom'].widget = BigMapWidget()

Of course, this problem only applies to generic Geometry field types, and those are commonly used.

[Tim Graham]

Eric, don't forget to link to your PR from the ticket and check "Has patch" so it's picked up for review.

Here's ​Eric's PR. It looks good to me but I'll let Claude or something more familiar with GeoDjango do a final review.

[Claude Paroz]

Eric, can you explain where the 102 number comes from in your patch? I'm not sure changing the OGR semantic is a good idea. I think we'd rather solve this in the forms/widgets layer. But I'm open to any other argument.

[Olivier Tabone]

claim the ticket, working on it during duth sprint.

[Olivier Tabone]

Looking at GDAL documentation, there is no OGR type matching 'POLYGON'. ​enum OGRwkbGeometryType

Hence the '102' magic number in the patch does not match OGR specification.

I agree with Claude we should not change OGR semantics. returning wkbUnknown for an empty geometry seems correct according to GDAL.

removed 'has patch' flag because the pull request has been closed quite a long time ago by tim.

[Mariusz Felisiak]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 7603036b:

Fixed #21021 -- Changed BaseGeometryWidget's default geometry type to 'Geometry'.