dateformat test fails on Windows (Python 2.4.2)

[a.lebedev@…]

When trying to run unit test suite against sqlite3 database you get one test failing:

D:\doc\study\django\alex>d:\django\tests\runtests  --settings=settings
Running tests with database 'sqlite3'

'dateformat' module: Error while importing
==========================================
  File "d:\django\tests\runtests.py", line 208, in run_tests
    mod = __import__("othertests." + module, '', '', [''])
  File "d:\django\tests\othertests\dateformat.py", line 76, in ?
    time.tzset()
AttributeError: 'module' object has no attribute 'tzset'

1 error:

Always reproduces. Using latest SVN (3091)

Environment:
Pyhton 2.4.2
Windows XP SP2

[Chris Beaven]

Just to be clear, it's not a database problem, it's the fact that .tzset() is only available in unix.

[Chris Beaven]

... and from my research, it's not coming to Win32 any time soon. I'm not sure what the solution is here. Perhaps just ignoring Win32 and splitting all the timezone dependant tests to a seperate module that only runs if tzset is available?

​pytz - World Time Definitions for Python is a great library for using proper ​tzinfo objects rather than just changing the local timezone for Python, but I doubt Django developers want any more dependancies.

[asmodai@…]

Given this ​thread I doubt you will get any decent tzset() working natively by Python.

Stuart Bishop, the guy of the ​pytz package, is actually one of the participants of that tzset() discussion.

Even on POSIX things are not standardised when it comes to the environment variable TZ.

[Chris Beaven]

fix so windows users can still run test suite

[Malcolm Tredinnick]

This looks good, although the tests should be in the opposite order (no_tz or ...) so that short-circuiting mean we bail out even attempting the path that is known to fail. Slightly better programming practice that way (more efficient in other circumstances, too). Dont' worry about making another patch, though. I'll apply this later this morning and fix it then.

[mir@…]

looks like this patch has already been applied.

[alsleme]

​فنادق
​القاهرة
​شرم الشيخ
​فنادق شرم الشيخ
​الاسكندرية
​مصر
​فنادق الاسكندرية
​دبي
​فنادق دبي
​فنادق الامارات
​فنادق كوالالمبور
​فنادق بينانج
​فنادق ماليزيا
​فنادق لنكاوي
​فنادق اسطنبول
​فنادق تركيا