TypeError: string indices must be integers

[amcnabb@…]

I created a manipulator with self.fields = [forms.FileUploadField('exportfile')]

When submitting the form with a file named 'testfile', there is an error message: "TypeError: string indices must be integers". Apparently isNonEmptyFile expects field_data to be a dictionary or something. The bottom of the trace is as follows:

/sw/lib/python2.4/site-packages/Django-0.91-py2.4.egg/django/forms/init.py in isNonEmptyFile

637.

638. class FileUploadField(FormField):
639. def init(self, field_name, is_required=False, validator_list=[]):
640. self.field_name, self.is_required = field_name, is_required
641. self.validator_list = [self.isNonEmptyFile] + validator_list 642.
642. def isNonEmptyFile(self, field_data, all_data):

644. if not field_datacontent: ...

645. raise validators.CriticalValidationError, gettext("The submitted file is empty.") 646.
646. def render(self, data):
647. return '<input type="file" id="%s" class="v%s" name="%s" />' % \
648. (self.get_id(), self.class.name, self.field_name)

650.

▼ Local vars
Variable Value
all_data
<MultiValueDict: {'exportfile': ['testfile']}>
field_data
'testfile'
self
FormField "exportfile"

[James Bennett]

Please send questions and general support requests to the Django users mailing list (​http://groups.google.com/group/django-users/); this system should only be used once you're certain you've found a bug in Django.

[Adrian Holovaty]

Closing (see previous comment).

[anonymous]

In FileUploadField.isNonEmptyFile(), it needs to check if field_data is dictionary-like before doing "if not field_datacontent". If so, it should give an error that enctype="multipart/form-data" was not specified in the form.

[Luke Plant]

Agreed that this is a real bug (I got caught in it just the other day myself), and the solution needs to take into account the fact that it is possible for an end user to alter a form and submit data how they like. So, even if the developer created his form correctly, an end user could trigger this error. Therefore Django should deal with it in such a way that a backtrace is avoided.

[Luke Plant]

(In [3048]) Fixed #2045 - TypeError thrown if a form does not have the correct enctype for uploading
files. It throws a ValidationError now, as it should.