forms.widgets.Widget._has_changed() erroneously returns True on Widgets with is_localized=True

[Jacob Rief]

How to reproduce:
In settings.py set USE_L10N=True and set your locale to a language which uses a comma as decimal separator.
Create a form with fields for Float or Decimal and give them an initial value.
On the corresponding widget, set is_localized=True.

If this form is rendered, the initial values are displayed using a comma instead of a dot. If the client resubmits this form without changing any value, the method forms.widgets.Widget._has_changed() erroneously returns True, because it compares a decimal string using a comma as decimal separator (from the input field) with a string using a dot (from the initial value).

The attached patch worked for me.

[Jacob Rief]

patch

[Claude Paroz]

Thanks, but this has already been reported in #16612.

[Jacob Rief]

In the 1.4.x stable branch, this bug still exists. When I filed it, it was on Version 1.4.3, now we have 1.4.5 and this bug still is there.

I noticed, that in Django>=1.5 a lot of code regarding this has been modified, but I can not upgrade to 1.5 yet and it is somehow embarrassing always having to patch Django-1.4.x manually to fix this.

I filed a pull request on github for this: ​https://github.com/django/django/pull/1268

[Luke Plant]

We don't backport bug fixes of this nature, sorry. ​https://docs.djangoproject.com/en/1.5/internals/release-process/#supported-versions