in ModelAdmin disabling has_add_permission results in not showing any object-tools

[a.fazeli@…]

in change_list.html when has_add_permission is false all the object-tools (buttons) are not shown, even if you have implemented some custom tools. This permission check should only be for the add button item.

I tweaked the code (very small change) that will fix this problem.

My proposal for this matter is attached to this ticket

[a.fazeli@…]

patch for ModelAdmin has_add_permission disabling all the object-tools-items

[Claude Paroz]

Makes sense. Please provide your attachment as patch/diff format.

[Ramiro Morales]

The relevant code is:

{% block object-tools %}
  {% if has_add_permission %}
    <ul class="object-tools">
      {% block object-tools-items %}
        <li>
          <a href="{% url cl.opts|admin_urlname:'add' %}{% if is_popup %}?_popup=1{% endif %}" class="addlink">
            {% blocktrans with cl.opts.verbose_name as name %}Add {{ name }}{% endblocktrans %}
          </a>
        </li>
      {% endblock %}
    </ul>
  {% endif %}
{% endblock %}

The extension strategy provided to developers wishing to implement custom tools is to override the whole object-tools block. The modification proposed by the OP would generate an empty UL element if the current user has no add permission for the normal case (no customization of the template). IMHO we need a better solution or simply leave thing as the are. Consider me -1 on the proposal in its current form.

[arash77]

How about this solution:

{% block object-tools %}
    <ul class="object-tools">
        <li style="display: none;"></li>
        {% block object-tools-items %}
            {% if has_add_permission %}
            <li>
                <a href="{% url cl.opts|admin_urlname:'add' %}{% if is_popup %}?_popup=1{% endif %}" class="addlink">
                    {% blocktrans with cl.opts.verbose_name as name %}Add {{ name }}{% endblocktrans %}
                </a>
            </li>
            {% endif %}
        {% endblock %}
    </ul>
{% endblock %}

This way an empty UL will not be created. Of-course the first LI can also be configured through relative CSS class.

[Igor Támara]

a pull request has been done from ​https://github.com/ikks/django/tree/ticket_19536 , added a test to make sure it works as expected.

[Tim Graham]

Left some comments on the ​PR.

[Nick Sandford]

Added a new PR: ​https://github.com/django/django/pull/5573.

[Marten Kenbeek]

The patch looks good to me.

[Tim Graham]

Left some minor comments.

[Tim Graham <timograham@…>]

In ff19df9:

Fixed #19536 -- Included object-tools when ModelAdmin.has_add_permission() is False.

[Tim Graham <timograham@…>]

In e73fb2c:

Refs #19536 -- Tweaked test assertion to avoid collision with CSRF token.