Opened 12 years ago
Closed 12 years ago
#18924 closed Bug (fixed)
test.Client.logout doesn't send user_logged_out signal
| Reported by: | awsum | Owned by: | fhahn |
|---|---|---|---|
| Component: | Testing framework | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | marc.tamlyn@…, flo@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As docs say user_logged_out signal should be send wherever logout method called. Instead of reusing contrib.auth.logout Client doing session clean up by it's own and doesn't send user_logged_out signal.
Change History (7)
comment:1 by , 12 years ago
| Has patch: | set |
|---|
comment:2 by , 12 years ago
| Cc: | added |
|---|---|
| Needs documentation: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 12 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Subject to release notes, this is now RFC.
comment:5 by , 12 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Patch has now gone stale - it will need updating for custom user models.
comment:6 by , 12 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Patch needs improvement: | unset |
| Status: | new → assigned |
I've updated the patch (after contacting the creator of the patch) and created a new pull request: https://github.com/django/django/pull/731
comment:7 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
There's one unused import in the current patch which I've highlighted on github.
This should be mentioned in release notes as someone may have signals which now get fired by their tests and are unexpected. There's probably no need to mention it in the normal docs though.