Opened 13 years ago
Closed 13 years ago
#18450 closed Cleanup/optimization (fixed)
Remove default values for i18n JavaScript URLs in Admin templates
| Reported by: | Daniel Hepper | Owned by: | Daniel Hepper |
|---|---|---|---|
| Component: | contrib.admin | Version: | 1.4 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Some templates in the admin contain a hard coded default value for the i18n JavaScript URLs:
admin/auth/user/change_password.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../../jsi18n/" }}"></script>
admin/change_form.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../jsi18n/" }}"></script>
admin/change_list.html: <script type="text/javascript" src="{{ jsi18nurl|default:'../../jsi18n/' }}"></script>
[11:02] apollo13: jezdez: https://github.com/django/django/commit/1e955e0143 you think we can remove the default:"../../" stuff by now? I think no admin site is able to have no jsi18n url by now
[11:04] apollo13: (more or less the only part of the admin still having relative urls at all)
[12:33] jezdez: apollo13: yes
Change History (4)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:4 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Readable version:
admin/auth/user/change_password.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../../jsi18n/" }}"></script> admin/change_form.html:<script type="text/javascript" src="{{ jsi18nurl|default:"../../../jsi18n/" }}"></script> admin/change_list.html: <script type="text/javascript" src="{{ jsi18nurl|default:'../../jsi18n/' }}"></script> [11:02] apollo13: jezdez: https://github.com/django/django/commit/1e955e0143 you think we can remove the default:"../../" stuff by now? I think no admin site is able to have no jsi18n url by now [11:04] apollo13: (more or less the only part of the admin still having relative urls at all) [12:33] jezdez: apollo13: yes