Add ModelAdmin.get_deleted_objects() hook

[Chris Wilson]

I want to increase control over who can delete what objects using the admin interface.

delete_view calls has_delete_permission(), which is fine, but then it calls get_deleted_objects() from django.contrib.admin.util.

This is very hard to override without monkey-patching get_deleted_objects(), because it requires replacing the whole of delete_view just to change one line.

I propose calling a member method get_deleted_objects(), which by default just calls the one from util, to make it easy to override this behaviour.

I've attached a patch without tests, because the existing tests should check that this doesn't break anything.

[Chris Wilson]

Patch to add get_deleted_objects() hook to ModelAdmin

[Luke Plant]

I'm accepting, but marking as 'needs tests', because although it is a simple change, we need tests that check that ModelAdmin.get_deleted_objects() is actually used. This has been our policy with other simple changes, like #14206 for ModelAdmin.get_list_display, and ListView.get_paginator.

[Rebecca Smith]

I have added PR ​#8267 to update the previously submitted patch and use the new ModelAdmin method in the default delete_selected action as well as delete_view.

[Tim Graham]

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" after updating.

[Tim Graham <timograham@…>]

In 8116e588:

Fixed #17962 -- Added ModelAdmin.get_deleted_objects().