#1659 closed defect (fixed)
[patch] [magic-removal] References to decomissioned "django.models" still exist
Reported by: | Chris Beaven | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Core (Other) | Version: | magic-removal |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In the magic removal branch, the following files still have references to django.models
which no longer exists:
django/contrib/auth/models.py django/contrib/comments/views/karma.py django/contrib/comments/views/userflags.py
Attachments (6)
Change History (17)
comment:1 by , 19 years ago
comment:2 by , 19 years ago
I'm not seeing anything out of place in the auth models file. It imports django.db.models, not django.models. The other two still need refactoring, though. Since I'm doing some stuff that relies on the comments app, I'll try to get that tomorrow at work.
by , 19 years ago
Attachment: | karma.diff added |
---|
Patch for karma.py to (hopefully) bring it in line with latest m-r
comment:3 by , 19 years ago
Summary: | [magic-removal] References to decomissioned "django.models" still exist → [patch] [magic-removal] References to decomissioned "django.models" still exist |
---|
comment:4 by , 19 years ago
Just made sure I had the latest version and yes to django.models
still.
Line 215 of auth models file:
module = __import__('django.models.%s' % settings.AUTH_PROFILE_MODULE, [], [], [''])
by , 19 years ago
Attachment: | models.diff added |
---|
Fix auth models file for m-r (and remove some Ellington cruft)
comment:7 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Is this fixed? Please reopen with specific stuff that still needs to be done, if there is any.
comment:8 by , 19 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
docs/forms.txt docs/overview.txt docs/request_response.txt docs/syndication_feeds.txt
Still contain references to django.models. There aren't any references in the code anymore however. I'll reopen this for now, but maybe these should be part of another ticket.
comment:9 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
We're still working on those docs, so I'm closing the ticket.
comment:10 by , 19 years ago
Summary: | [patch] [magic-removal] References to decomissioned "django.models" still exist → [patch] [magic-removal] References to decomissioned "django.models" still exist |
---|
Oh yea, also: