Broken sentence in modelforms topic doc

[Jeff Blaine]

Error in ​http://docs.djangoproject.com/en/1.3/topics/forms/modelforms/

This makes no sense that can figure out:

The first time you call is_valid() or access the errors attribute of a ModelForm has always triggered form validation, but as of Django 1.2, it will also trigger model validation.

[Aymeric Augustin]

The sentence makes sense for me: $ACTION has always done $FOO, and since Django >= 1.2, it also does $BAR.

But it's needlessly complex.

[Aymeric Augustin]

Attached patch proposes a simplified wording.

The fact that validation only happens the first time either is_valid is called or errors is accessed is no longer stated explicitly—I think it is obvious in the context.

[Jeff Blaine]

Much clearer.

[anonymous]

I don't think the sentance that aaugustin proposed has the same meaning as the original. it should be:

"As of Django 1.2, the model validation is triggered in addition to the default behavior of older versions (triggering the form validation) by calling is_valid() or accessing the errors attribute of the ModelForm."

or

"As of Django 1.2 calling is_valid() or accessing the errors attribute of the ModelForm will trigger model validation in addition to form validation."

[Tim Graham]

Since we should technically be removing the versionadded/changed tags that reference 1.2 in the 1.4 docs, I'm going to remove the reference to Django 1.2 here which will simplify things.

[Tim Graham]

In [16329]:

Fixed #15990 - Simplified a sentence regarding form validation for ModelForms; thanks jblaine for the suggestion.