Opened 14 years ago
Closed 12 years ago
#15223 closed Bug (wontfix)
The comments app has 2 similar menu items in action
| Reported by: | Owned by: | Ashutosh Dwivedi | |
|---|---|---|---|
| Component: | contrib.comments | Version: | 1.3-beta |
| Severity: | Normal | Keywords: | actions |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
There are two menu items:
- Delete selected items
- Remove selected items
I guess one from admin app and one from comments app.
Change History (13)
comment:1 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:4 by , 14 years ago
No doubt originally named after the is_removed field on the Comment model, which seems perfectly reasonable until you see it beside the site-wide delete action. Should be a one-line patch. I think "Unpublish selected" sounds appropriate? (describes the effect better than "deactivate" or "hide").
comment:5 by , 14 years ago
| milestone: | 1.4 → 1.3 |
|---|
Julien, I disagree, this is a bug, even more a one-line translatable literal change. Can be worked on before 1.3 RC.
comment:6 by , 14 years ago
@Ramiro Functionally things are consistent but I agree that this can be seen as a usability bug, and I'm absolutely in favour of fixing this ASAP. The patch may not be as trivial as modifying one string though. The term "removed" is also used in the comment's detail page and in the changelist's table and filters. If we change the term only in some places then things may potentially get even more confusing for the user.
comment:7 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
comment:13 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
I've made a pull request for the patch here https://github.com/aashudwivedi/django/tree/ticket_15223
comment:14 by , 12 years ago
This is perhaps bikeshedding, but "unpublish/is unpublished" seems pretty clumsy language to me. "hide/is hidden" would be a lot better IMO.
comment:15 by , 12 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
django.contrib.comments has been deprecated and is no longer supported, so I'm closing this ticket. We're encouraging users to transition to a custom solution, or to a hosted solution like Disqus.
The code itself has moved to https://github.com/django/django-contrib-comments; if you want to keep using it, you could move this bug over there.
I agree that this is confusing (I had to explain the difference between "Delete" and "Remove" to several clients before). "Remove" should perhaps be changed to "De-activate", or "Un-publish" or something along those lines.