SiteProfileNotAvailable needs silent_variable_failure=True

[tkolar]

This makes sense in the context of #15097. If I understand this correctly, the problem from #15097 should exist in the dev version (because of the behavior detailed in the paragraph directly above ​http://docs.djangoproject.com/en/dev/ref/templates/api/#how-invalid-variables-are-handled). My guess is that this is exactly the type of thing that silent_variable_failure is there for, and SiteProfileNotAvailable does not have silent_variable_failure=True in SVN. I have attached a models.py that fixes this.

[tkolar]

Version of models.py that sets django.contrib.auth.models.SiteProfileNotAvailable.silent_variable_failure=True

[tkolar]

Sorry for the dead link in the file description - no idea how that happened.

[Russell Keith-Magee]

Seems like a reasonable suggestion. I can't think of any reason that get_profile should raise an exception during template rendering.

For future reference, please upload patches, rather than full files. Patches should also include tests to validate that the change does what it says.

[tkolar]

Patch that implements the proposed change, test included

[tkolar]

Done ;)

[tkolar]

Should the severity of this bug really be "normal"? If it isn't fixed, every template that does {{ user.get_profile.<some_field> }} will be broken if users do not necessarily have a profile. Besides, there is no other reliable way to get profile fields at all in the given situation without changing the view. Also, my patch fixes it already.

[tkolar]

And since all that anyone has to do with this patch to implement it is apply it, I set "easy pickings".

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Ludovic Delaveau]

Bumping the ticket, looks ready for checkin with respect to the previous discussion.
If needed, pull request is at ​https://github.com/django/django/pull/449

[Florian Apolloner]

Django 1.5 will ship with a new method to add data to the user model and as such the current AUTH_PROFILE_MODULE is deprecated and will go away (including stuff like get_profile). As a result of the deprecation we won't fix any non critical bugs. Sry that we couldn't get this in earlier.