1.2.4 regression: send_mail doesn't access email recipient with no domain

[net147]

Sending email using django.core.mail.send_mail fails to send to an email recipient that is just the username on the current system (e.g. joe instead of joe@localhost).
This worked fine in Django 1.2.3 but no longer works in Django 1.2.4 (throws a ValueError trying to split the email by @ into name and domain).

[Russell Keith-Magee]

To clarify - this only affects the SMTP backend. Code was broken by r15006, fixing #14301, because there's no existing test for the behavior described.

Mail tests should probably be backend-duplicated like the tests for cache backends.

[Łukasz Rekucki]

Started refactoring of regressiontests/mail/tests.py. Shouldn't take long.

[Łukasz Rekucki]

Patch against trunk.

[Łukasz Rekucki]

The right patch against trunk.

[Łukasz Rekucki]

The patch contains:

• Refactored tests for mail handling:
  • MailTests class contains test cases related to EmailMessage class that don't depend on any backend.
  • BaseEmailBackendTests contains all other tests that involve actually sending any messages.
  • FakeSMTPServer using Python's smptd module for testing the SMTP backend. This runs in another thread for the duration of the testcase.
• Correct handling of IDN: all headers that contain email addresses must be sanitized properly. Otherwise, the whole header will be encoded as "quoted-printable", thus loosing it's structure. I tried sending some emails to a localy defined IDN and Postfix treats the value in From: =?utf-8?b?ZnLDtm1Aw7bDpMO8LmNvbQ==?= as it was a mailbox name.
• Some support for non-ASCII characters in local-part of the email (they're encoded as they we're before).
• A fix and a regression test for this issue.

Note: Backporting to 1.2.X involves moving some code from setUpClass/tearDownClass in SMTPBackendTests to setUp/tearDown. Should I make a seperate patch ?

[Russell Keith-Magee]

(In [15211]) Fixed #15042 -- Ensured that email addresses without a domain can still be mail recipients. Patch also improves the IDN handling introduced by r15006, and refactors the test suite to ensure even feature coverage. Thanks to net147 for the report, and to Łukasz Rekucki for the awesome patch.

[Russell Keith-Magee]

(In [15213]) [1.2.X] Fixed #15042 -- Ensured that email addresses without a domain can still be mail recipients. Patch also improves the IDN handling introduced by r15006, and refactors the test suite to ensure even feature coverage. Thanks to net147 for the report, and to Łukasz Rekucki for the awesome patch.

Backport of r15211 from trunk.

[Jacob]

Milestone 1.3 deleted

[Carlton Gibson <carlton@…>]

In 1564e42a:

Refs #30512, #15042 -- Added local-only address to sanitize_email() tests cases.

email.headerregistry.parser.get_mailbox() returns a token with a token_type attribute.

If token_type is ’invalid-mailbox’ then RFC violations have been detected. Emails with only the local part, and no domain, are correctly parsed but are marked as ’invalid-mailbox’.

As per #15042, local-only are supported, to enable sending to addresses on localhost.

sanitize_email() does not currently check token_type. This test is added to avoid a regression in case this is revisited in the future.