Crash on HEAD request

[azurit]

Traceback (most recent call last):

  File "/usr/lib/python2.5/site-packages/django/core/handlers/base.py", line 94, in get_response
    response = middleware_method(request, callback, callback_args, callback_kwargs)

  File "/usr/lib/python2.5/site-packages/django/middleware/doc.py", line 15, in process_view
    if request.method == 'HEAD' and (request.META.get('REMOTE_ADDR') in settings.INTERNAL_IPS or (request.user.is_authenticated() and request.user.is_staff)):

AttributeError: 'WSGIRequest' object has no attribute 'user'

[Alex Gaynor]

Reformatted, please use the preview button in the future.

[pandres]

Please give us more information on how to reproduce. Also try a newer django version.

[Jannis Leidel]

Looks like request.user is not set. Which means the Auth middleware was not successfully run.

[azurit]

Replying to jezdez:

Looks like request.user is not set. Which means the Auth middleware was not successfully run.

Yes, Auth middleware is NOT loaded.

[Karen Tracey]

Replying to azurit:

Replying to jezdez:

Looks like request.user is not set. Which means the Auth middleware was not successfully run.

Yes, Auth middleware is NOT loaded.

If you don't have the auth middleware loaded, why do you have the XView middleware loaded (that's the code that is generating the exception)? That middleware is documented (​http://docs.djangoproject.com/en/dev/ref/middleware/#django.middleware.doc.django.middleware.doc.XViewMiddleware) as providing some function for the admindocs feature, which is only accessible from admin, which requires the auth middleware to be in place. So XView assumes auth middleware is loaded.

Leaving open since I guess the XView code could handle this more gracefully, but the easiest fix would seem to be for you to remove it from your middleware setting.

[azurit]

Replying to kmtracey:

Replying to azurit:

Replying to jezdez:

Looks like request.user is not set. Which means the Auth middleware was not successfully run.

Yes, Auth middleware is NOT loaded.

If you don't have the auth middleware loaded, why do you have the XView middleware loaded (that's the code that is generating the exception)? That middleware is documented (​http://docs.djangoproject.com/en/dev/ref/middleware/#django.middleware.doc.django.middleware.doc.XViewMiddleware) as providing some function for the admindocs feature, which is only accessible from admin, which requires the auth middleware to be in place. So XView assumes auth middleware is loaded.

Leaving open since I guess the XView code could handle this more gracefully, but the easiest fix would seem to be for you to remove it from your middleware setting.

Thank you, i removed XView middleware. Maybe documentation should mention that XView depends on Auth ?

[Klaas van Schelven]

Assert the right middleware is running similar to contrib.auth.middleware

[Klaas van Schelven]

Added dependency description to the docs (I'm not too sure on the format, so please test first)

[Horst Gutmann <zerok@…>]

Patch still applies cleanly to trunk.

[Jannis Leidel]

In [16496]:

Fixed #14506 -- Added an assertion to XViewMiddleware about the dependency on the authentication middleware. Thanks, vanschelven.