Implement subqueries in geodjango spatial lookup

[milosu]

Currently only GEOS geometry objects can be used in the GeoQuerySet spatial field lookups. Sometimes the geometry objects are very large geometries on its own and the resulting SQL statement that includes EWKB of the geometry is very large (lets say 30 mega bytes in my case).

Attached patch extends GeoDjango ORM to support subqueries in spatial lookups, so that it is possible to make a query like:

  qset = Address.objects.filter(location__within = District.objects.filter(name='Boston area').values('area'))

so that the resulting spatial SQL looks like:

SELECT "spatial_subquery_address"."id", "spatial_subquery_address"."city", "spatial_subquery_address"."location"
FROM "spatial_subquery_address"
 WHERE ST_Within("spatial_subquery_address"."location", (SELECT U0."area" FROM "spatial_subquery_district" U0 WHERE U0."name" = Boston area ))

See attached regression test for this enhancement.

Patch was built against slightly modified Django 1.2.3 so that it will not apply cleanly, but I hope jbronn or someone else should get the idea from my attached version.

[milosu]

performance improvement for postgis, that allows postgres to efficiently replace subselect with its result while preparing the query plan

[Russell Keith-Magee]

Seems reasonable, but I'll let a GeoDjango expert make the final call.

[milosu]

improved patch passing GeoDjango and Django test suite (solved SQLEvaluators related problems)

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Aymeric Augustin]

No GeoDjango expert made the call, and it still seems reasonable.

[Tim Graham]

Patch will need to be updated to apply cleanly.

[Claude Paroz]

I have a branch where this is working with PostGIS.
​https://github.com/claudep/django/commit/53783c93a551fe769d5395e6ee54d01729b23722

However, it still fails on MySQL and Spatialite because of the ops.select format (AsText()) which is applied to the subquery select. I don't know if there is a mean to prevent that special formatting for subqueries. ORM master needed :-)

[Claude Paroz]

#24164 resolution (thanks Tim!) allows now the current PR to pass on MySQL/Spatialite also.

[Claude Paroz <claude@…>]

In a0b5f15ea5f1abd91da9a5e4e5b6a0fb5a880c43:

Fixed #14483 -- Allowed using subqueries with GIS lookups

[Claude Paroz <claude@…>]

In c77dd64402e64e3e53b49634175f1e010a480b67:

[1.8.x] Fixed #14483 -- Allowed using subqueries with GIS lookups

Backport of a0b5f15ea5f from master.