Fixture loading should be skipped for TestCase decorated with @skip*

[Piotr Czachur]

TransactionTestCase overrides unittest.TestCase.__call__() and always runs _fixture_setup(), even for skipped tests (decorated with @skip* from unittest).
It makes no sense at all and it's really waste of time to wait for those fixtures to load.

class TransactionTestCase(unittest.TestCase):
    def _pre_setup(self):
        """Performs any pre-test setup. This includes:

            * Flushing the database.
            * If the Test Case class has a 'fixtures' member, installing the
              named fixtures.
            * If the Test Case class has a 'urls' member, replace the
              ROOT_URLCONF with it.
            * Clearing the mail test outbox.
        """
        self._fixture_setup()
        self._urlconf_setup()
        mail.outbox = []

    # ...

    def __call__(self, result=None):
        """
        Wrapper around default __call__ method to perform common Django test
        set up. This means that user-defined Test Cases aren't required to
        include a call to super().setUp().
        """
        self.client = Client()
        try:
            self._pre_setup()   # LOAD FOR EVERY TestCase
        except (KeyboardInterrupt, SystemExit):
            raise
        except Exception:
            import sys
            result.addError(self, sys.exc_info())
            return
        super(TransactionTestCase, self).__call__(result)  # HERE @skip* decorators are honoured

[Piotr Czachur]

It's related to #12991

[Paul McMillan]

I assume this applies when the patch from #12991 is applied and/or you're using Python 2.7 to test your app. I'm assigning this to myself, but I probably won't actually fix the problem until #12991 is resolved.

[Paul McMillan]

More broadly, the test running framework needs some cleanup in light of the changes to unittest, so this may get rolled into that.

[Piotr Czachur]

Paul,
in fact I'm using unittest from 2.7 under Python 2.6 (I'm aware of existence unittest2, but unitest from 2.7 works just fine for me).
Cheers.

[Ramiro Morales]

In [16369]:

(The changeset message doesn't reference this ticket)

[Piotr Czachur]

r16369 introduced new bug: #16372

[Ramiro Morales]

In [16579]:

Fixed #16372 -- Changed strategy implemented in r16369 to fix #14049 to avoid affecting the statistics of test cases ran/skipped kept by unittest. Thanks zimnyx for the report.