submit_row templatetag should pass whole context

[drul]

django submit_row inclusion tag doesn't pass extra_context from ModelAdmin.(add|change|..)_view to submit_row.html template. Because of that, i cannot add extra button to submit row (i.e. print invoice). this tag should pass whole context to the template

[drul]

patch

[Ramiro Morales]

See also #11974.

[Julien Phalip]

This is technically a new feature and therefore I'm removing the 1.3 milestone since we're in beta stage right now. Passing the whole context to the template is a good thing, however the general context should not be modified with the {% submit_row %}'s specific variables (as done in drul's patch). Instead a disposable specific new context should be passed through (as done in my suggested patch).

[patchhammer]

13875_submit_row_whole_context.diff fails to apply cleanly on to trunk

[Alexander Herrmann]

fixed patch for current source

[benatkin]

Another thing: it would be nice if I could individually override the button row in a template. In change_form.html there's:

{% submit_row %}

If it got changed to something like:

{% block submit_button_row %}
    {% submit_row %}
{% endblock %}

I could override it individually. In fact, I copied the entire change_form.html from django/contrib/templates to my own template directory and made this modification for my project.

[benatkin]

I realize I could also override the template tag, but this makes it easier to modify one change form without having to worry about messing up the other change forms.

[Ramiro Morales]

In [16956]:

Fixed #9460 -- Added template blocks for submit buttons rows in admin app model add/change views.

This allows for easier customization. Thanks kosmik for report and patch.

Refs #13875.

[Federico Capoano]

it is not clear if the patch needs improvements or not.

[Federico Capoano]

Just opened PR ​https://github.com/django/django/pull/6078.

A more paranoid test could be written, like creating a custom app with an admin that extends the context, loads a modified version of the subimt_row template and check the extended context is available in the template. But I think all the complexity needed wouldn't add much value.

Federico

[Tim Graham <timograham@…>]

In e972a7d0:

Fixed #13875 -- Made admin's submit_row template tag pass whole context.