XViewMiddleware fails with django.contrib.syndication.views.Feed

[ch0wn]

When doing a HEAD request on a class-based view, while having XViewMiddleware enabled, an error occures when accessing view_func.__name__, as an instance does not provide a __name__ attribute.

Example

views.py

# mapped to /1
def simple_function(request):
    return HttpResponse("Hello World")


# mapped to /2
class SimpleClass(object):
    def __call__(self, request):
        return HttpResponse("Hello World")

» curl -I http://localhost:8000/1
HTTP/1.0 200 OK
Date: Sun, 27 Jun 2010 20:10:25 GMT
Server: WSGIServer/0.1 Python/2.6.5
X-View: djangoheadfix.views.simple_function
Content-Type: text/html; charset=utf-8

» curl -I http://localhost:8000/2
HTTP/1.0 500 INTERNAL SERVER ERROR
Date: Sun, 27 Jun 2010 20:10:56 GMT
Server: WSGIServer/0.1 Python/2.6.5
Content-Type: text/html

I'm going to attach a patch for this.

[Alex Gaynor]

This patch almost certainly doesn't do what you want. Every single instance of a new style class, in all of python, has an __class__ attribute.

[ch0wn]

I'm not sure know if this is a much better idea, but at least it works correctly.

[Matthias Kestenholz]

See #6735 too (adding class-based generic views to Django)

[Russell Keith-Magee]

The class-based views introduced by #6735 don't have this problem. I'll add some tests to confirm this for regression purposes.

[Russell Keith-Magee]

(In [14269]) Fixed #13842 -- Added tests to verify that XViewMiddleware works with class-based views.

[Łukasz Rekucki]

I'm going to reopen this, because it looks like django.contrib.syndication.views.Feed suffers from this erro (see ​this thread on django-users). So either we need to fix this or migrate syndication views to the new CBV framework.

[Tim Graham]

I think the failure was caused by old style classes in Python 2.5. Seems to work based on this test:

>>> from django.contrib.syndication.views import Feed
>>> Feed = view_func
>>> view_func.__module__, view_func.__name__
('django.contrib.syndication.views', 'Feed')