Opened 14 years ago
Closed 14 years ago
#13840 closed (fixed)
404 error reported via e-mail even when DEBUG is True
| Reported by: | master | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Keywords: | 404, broken link | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
According to http://docs.djangoproject.com/en/dev/howto/error-reporting/, "DEBUG is False" is one of the conditions for 404 errors to be reported via e-mail.
But they are, whatever the state of this setting.
The attached patch adds the mandatory condition.
Attachments (1)
Change History (4)
by , 14 years ago
| Attachment: | 404email.diff added |
|---|
comment:1 by , 14 years ago
comment:2 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
I'd say the code is wrong. Sending mail is generally the production behavior, for when the special debug 404 and 500 views are not available. If the debug 404 page has been sent as a response, then the mail should not be sent.
comment:3 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This has been reported again in #15187 and has been fixed.
Note:
See TracTickets
for help on using tickets.
I noticed this behaviour this week and was surprised by it myself. I guess the decision here really is if the code is wrote on the documentation.