UK localflavor mis-named/documentation bug.

[Matthew Schinckel]

The documentation for localflavor states that:

Inside that package, country- or culture-specific code is organized into subpackages, named using ISO 3166 country codes.

However, the ISO 3166 code for the United Kingdom is actually GB. Thus, anything that uses ISO 3166 codes to store countries (such as django-countries) will be unable to automatically get the correct localflavor information.

Since changing this would break existing code, perhaps there could be another gb module that just shadows the uk module.

For instance, in gb/forms.py, we might have:

from django.contrib.localflavor import uk
GBPostcodeField = uk.UKPostcodeField
GBCountySelect = uk.UKCountySelect
GBNationSelect = uk.UKNationSelect

This means that all is needed is this file, and any changes to the uk one will also apply to gb.

[Fraser Nevett]

I raised this issue previously in #8323. As this ticket has been accepted and has a proposed patch, I closed the older ticket in favour of this one.

[Claude Paroz]

We cannot leave the uk directory occupied by the gb content, because uk is the code for Ukrain. So we have to move files and follow a deprecation path in the current uk directory.

[anonymous]

Just to correct comment 5, UA is the code for Ukraine. UK is "exceptionally reserved" for the United Kingdom (see ​http://www.iso.org/iso/iso-3166-1_decoding_table#UK).

[Claude Paroz]

Thanks for the correction, I mixed up uk ISO 639-1 for Ukrainian language and UA the ISO 3166 country code for Ukraine. It is not referenced in the patch, though.

[Jannis Leidel]

In [16147]:

Fixed #13729 -- Renamed UK localflavor to GB to correctly follow ISO 3166. Thanks, Claude Paroz.