a bug in a catch-all try..except in Django masks other exceptions: local variable 'resolver' referenced before assignment

[Antti Kaihola]

I ran into this when my custom settings for running unit tests didn't include ROOT_URLCONF, and others have seen this too
(​1,
​2,
​3).

In django.core.handlers.base.get_response, the resolver variable is defined inside a try: block and referenced in the final catch-all except: block. I'd move setting up the default url resolver outside the try..except block since a problem there probably prevents rendering 500 pages.

[Antti Kaihola]

moves default url resolver setup outside try..except

[Antti Kaihola]

Here's the traceback I got before applying the patch:

Traceback (most recent call last):
  File "myapp/tests.py", line 14, in test_example
    self.client.post('/', {})
  File "django/django/django/test/client.py", line 322, in post
    response = self.request(**r)
  File "django/django/django/test/client.py", line 230, in request
    response = self.handler(environ)
  File "django/django/django/test/client.py", line 74, in __call__
    response = self.get_response(request)
  File "django/django/django/core/handlers/base.py", line 142, in get_response
    return self.handle_uncaught_exception(request, resolver, exc_info)
UnboundLocalError: local variable 'resolver' referenced before assignment

This is the proper traceback after applying the patch:

Traceback (most recent call last):
  File "myapp/tests.py", line 14, in test_example
    self.client.post('/', {})
  File "django/django/django/test/client.py", line 322, in post
    response = self.request(**r)
  File "django/django/django/test/client.py", line 230, in request
    response = self.handler(environ)
  File "django/django/django/test/client.py", line 74, in __call__
    response = self.get_response(request)
  File "django/django/django/core/handlers/base.py", line 73, in get_response
    urlconf = settings.ROOT_URLCONF
  File "django/django/django/utils/functional.py", line 277, in __getattr__
    return getattr(self._wrapped, name)
AttributeError: 'Settings' object has no attribute 'ROOT_URLCONF'

[brendoncrawford]

The first patch does not work for me. I have attached a patch above that works for me.

[sbc]

updating to apply to head

[Alex Gaynor]

(In [14488]) Fixed #13684 -- if settings.ROOT_URLCONF isn't defined don't blow up with an UnboundLocalError.

[Jacob]

Milestone 1.3 deleted

[anatoly techtonik <techtonik@…>]

In which version it is fixed?

[anatoly techtonik <techtonik@…>]

Fixed in Django 1.3. Not backported to 1.2