IntegerField has no attributes max_value and min_value (1.2 regression)

[Miloslav Pojman]

Attributes min_value and max_value are no longer set on IntegerField, FloatField and DecimalField in Django 1.2.

Note these attributes are documented: ​http://docs.djangoproject.com/en/dev/ref/forms/fields/#django.forms.IntegerField.max_value.

I'm using them to generate some javascript validation.

[Sasha Romijn]

I haven't seen the old code, but it seems IntegerField now does min/max using django.core.validators. The fields are indeed not set in the code.
I think the documentation is not very clear on whether or not these fields should exist.

So, either the fields should be added, or the documentation should be clarified so that it doesn't suggests these fields being there.
I don't see an easy alternative to get them from the field instance.

[Sasha Romijn]

This would probably actually fit better in DDN.

[Miloslav Pojman]

This can be easily fixed by setting a field attribute in addition to adding a validator - similar to current CharField implementation.

The problem with this approach is that attribute value and validator can become easily inconsistent. Therefore from my point of view the design decision needed here is whether form field attributes are mutable or not. For example: Can be CharField min_length set in form init method?

I am attaching more tests.

[Russell Keith-Magee]

The documentation says "Takes two optional arguments for validation". It makes no guarantees about the field having an attribute. However, it's trivial to fix, and other attributes (e.g., max_digits on DecimalField, max_length on CharField), so it's worth doing.

[Russell Keith-Magee]

(In [15194]) Fixed #13631 -- Made sure that max_length and min_length are retained as attributes on form fields. Thanks to mila for the report.

[Russell Keith-Magee]

(In [15195]) [1.2.X] Fixed #13631 -- Made sure that max_length and min_length are retained as attributes on form fields. Thanks to mila for the report.

Backport of r15194 from trunk.