Need a contextprocessor for current site

[Artem Skoretskiy]

If you use Sites app you would need to use current site instance in your templates. For that purpose there should be a ContextProcessor in django.contrib.sites application.

The code is quite simple, but it makes no sense to create and store it in user's application:

from django.contrib.sites.models import Site

def current_site(request):
    return {'SITE': Site.objects.get_current()}

I can provide a patch if needed.

[Joshua Ginsberg <jag@…>]

Adds context processor, enables by default, updates docs, and implements tests

[Joshua Ginsberg <jag@…>]

Took a stab at it. Let me know if there are changes that should be made to the patch.

[Gabriel Hurley]

This patch looks good to me, with the one exception: it probably needs a backwards incompatibility note for those spots where you removed the site variable being manually added to the context. If someone was relying on that variable being available in those specific cases and doesn't add the context processor they're going to find their code is suddenly broken.

[Julien Phalip]

See also #10944 which suggests adding a template tag and a method to the Site class for this.

[patchhammer]

django-13559.patch fails to apply cleanly on to trunk

[Jacob]

Milestone 1.3 deleted

[Artem Skoretskiy]

Joshua Ginsberg, could you please update your patch to match current trunk?

I got no luck applying it to the revision given in patch file as well..

[Christoph Schindler]

Updated patch for r17913

[Christoph Schindler]

I updated the patch to apply against current trunk.

Had to fix the unit test as well, but I'm not entirely sure it's OK.

[Artem Skoretskiy]

Thanks, hop!

patchhammer, could you apply the patch over trunk?

[Christopher Medrela]

I did some minor changes in hop's patch:

• Repaired a few broken links at ​/ref/contrib/sites.txt doc.
• Added note at ​/ref/settings/#template-context-processors.
• Sites tests used ​django.views.generic.simple.direct_to_template function which comes from old function-based generic views which were permanently deleted. This made some tests broken. ​django.view.generic.TemplateView is used now and all tests pass.
• Refactored context processors' tests -- joined ContextProcessorTest and RequestSiteContextTest, tests use ​django.test.utils.override_settings instead of overriding settings in setUp and tearDown.
• Formatted in PEP8 style.

[Aymeric Augustin]

#17005 is about adding a middleware for the same purpose in views.

With that middleware and the request context processor, the current site will be available in {{ request.site }}, but that doesn't rule out a specific context processor in case you don't want the site middleware or the request context processor.

[chrismedrela]

I've updated the patch: ​https://github.com/django/django/pull/1938. BTW, krzysiumed is my old nick.

[Aymeric Augustin]

See my comments on the pull request.

[Tim Graham]

I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.