Add settings.FILE_UPLOAD_DIRECTORY_PERMISSIONS

[jacob@…]

Hi.
In core/files/storage.py, FILE_UPLOAD_PERMISSIONS is used to set the permissions of created files. It also makes the containing directory if it doesn't exist, but doesn't set the permissions for this directory. One possible patch is attached.

I can imagine cases where one would want the directory permissions to be different from file permissions. I'm not sure how objectional new setting names are.

Thanks.

[Russell Keith-Magee]

Good suggestion, but:

1. Patch should be generated as a diff against the root of the source tree
2. Patch requires tests
3. Patch probably also needs a note added to documentation describing the permissions that new directories will be created with

As for introducing a new FILE_UPLOAD_DIRECTORY_PERMISSIONS setting; while we generally try to avoid introducing new settings, in this case it makes sense to me. However, this also means extra documentation for point (3).

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Raumkraut]

The lack of this feature hit me a few days ago, so I've worked up a fix, taking into account the given suggestions.

The commit in question:
​https://github.com/Raumkraut/django/commit/1c0fe5d1c09bb3210812e32b88577c4572520f40

Since this is my first Django commit, and the ticket is somewhat old, there are some things I'm not certain are "correct":

• The documentation sections I've added defer explanation of the intricacies of file permissions to the existing FILE_UPLOAD_PERMISSIONS entries, in preference to duplicating the information.
• Since os.makedirs accounts for the system umask, and os.chmod doesn't, I've added code to temporarily zero out the umask while the directories are created. The intent is to maintain consistency of behaviour between the two settings.

Are these acceptable implementations, or do I need to tweak further before I send out a pull request?

[Raumkraut]

I've gone ahead and created a pull request with my patch: ​https://github.com/django/django/pull/1225
Hopefully someone can take a look at it?

[Tim Graham]

Comments on PR.

[Tim Graham <timograham@…>]

In 6bdb3b1135d1bd7b2dc24131b9d26ac19ebdba67:

Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting

This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.

Thanks jacob@ for the suggestion.