Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#12803 closed (fixed)

Provide styling for warning and error messages

Reported by: Beat Bolli Owned by: Simon Meers
Component: contrib.admin Version: 1.2-beta
Severity: Keywords: admin messages icons
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The new contrib.messages framework provides for different message levels. The admin interface styles all of them in the same way, with an "OK" icon. This patch adds some distinguishing styling for warning and error messages.

Attachments (2)

message-style.diff​ (1.4 KB ) - added by Beat Bolli 15 years ago.
CSS and template patch
admin_message_icons.diff​ (1.2 KB ) - added by Simon Meers 15 years ago.
DRYer CSS, alternate icon for warnings (though maybe less visual emphasis)

Download all attachments as: .zip

Change History (11)

by Beat Bolli, 15 years ago

Attachment: message-style.diff​ added

CSS and template patch

comment:1 by Beat Bolli, 15 years ago

Sorry, this is a Git patch that needs to be applied with patch -p1.

comment:2 by Alex Gaynor, 15 years ago

Triage Stage: Unreviewed → Accepted

by Simon Meers, 15 years ago

Attachment: admin_message_icons.diff​ added

DRYer CSS, alternate icon for warnings (though maybe less visual emphasis)

comment:3 by Simon Meers, 15 years ago

Cc: drmeers@… added
Keywords: admin messages icons added

(was just about to submit this as a new issue, but found this one with an almost identical patch)

comment:4 by James Bennett, 15 years ago

milestone: 1.2 → 1.3

This is really a feature request, and so can't go on 1.2.

in reply to:  4 comment:5 by Simon Meers, 15 years ago

Replying to ubernostrum:

This is really a feature request, and so can't go on 1.2.

Couldn't preventing error messages from being displayed with a green tick be considered a bugfix?! Plus the patch is dead simple...

comment:6 by Simon Meers, 15 years ago

Cc: drmeers@… removed
Owner: changed from nobody to Simon Meers
Status: new → assigned

comment:7 by Luke Plant, 15 years ago

Resolution: → fixed
Status: assigned → closed

(In [13393]) Fixed #12803 - Added styling for 'error' and 'warning' messages in admin.

Thanks to bboli and sebastian_noack for the report, DrMeers for the patch.

comment:8 by Luke Plant, 15 years ago

(In [13394]) [1.2.X] Fixed #12803 - Added styling for 'error' and 'warning' messages in admin.

Thanks to bboli and sebastian_noack for the report, DrMeers for the patch.

Backport of [13393] from trunk. Considered a bug (and therefore backported)
due to error and warning messages being styled with green tick previously.

comment:9 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top