admin action templates cannot be overriden on a per-app basis

[Ben Jackson]

For example, if you want to customize the 'actions' dropdown menu you might think you could copy in actions.html and modify it. However, it is rendered in change_list.html by calling the admin_actions templatetag. Those templatetags use register.inclusion_tag which does not search for application- or model-specific versions of a template.

You can't even work around it by overriding callers like change_list.html without also overriding the templatetag (copying it and changing the template name).

[Tay Ray Chuan]

contrib.admin: refactor updating of action_index to not use inclusion tag

[Tay Ray Chuan]

I have separated my fix into two parts:

1. ​http://code.djangoproject.com/attachment/ticket/12566/0001-contrib.admin-refactor-updating-of-action_index-to-n.patch Part 1: The only reason for the template tag {%admin_action%} was to update the variable action_index in the context. The patch replaces it with a tag {% get_action_index %} to just spit out a value to be used as the action index, without template inclusion. The action template admin/actions.html is now included manually via {% include %} in admin/change_list.html.

2. ​http://code.djangoproject.com/attachment/ticket/12566/0002-contrib.admin-allow-overriding-of-action-template-at.patch Part 2: Add some code to change_view select which template to use for the action form. I followed the style of template selection (eg. self.<thing>_template, followed by admin/mod/obj/<thing>.html, followed by...) from what we are already doing, eg. for change list, change form.

[Tay Ray Chuan]

Replying to rctay:

1. ​http://code.djangoproject.com/attachment/ticket/12566/0001-contrib.admin-refactor-updating-of-action_index-to-n.patch Part 1: The only reason for the template tag {%admin_action%}

I meant "The only reason for...to be around".

[Tay Ray Chuan]

admin/change_list.html: strip trailing whitespace

[Tay Ray Chuan]

ref/contrib/admin/index: document action_template

[Tay Ray Chuan]

contrib.admin: allow overriding of action template at app-level

[Tay Ray Chuan]

Replaced patch so that app-level overriding of templates work.

[Tay Ray Chuan]

Please pardon me if the status is inappropriate; it's my first time advancing a ticket's triage stage.

[Ramiro Morales]

Ideally, ticket stage field changes to accepted or ready for checkin shouldn't be performed by patch submitter and/or ticket reporter. Review by another pair of eyes is preferred, see ​http://docs.djangoproject.com/en/1.1/internals/contributing/#triage-by-the-general-community

Also, please merge all the patches in one file.

[Tay Ray Chuan]

Removed stray print.

[patchhammer]

0001-contrib.admin-allow-overriding-of-actions.html-templ.patch fails to apply cleanly on to trunk

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Carlton Gibson]

This was resolved by #27728, which allowed overriding admin templatetag's templates.