Hardcoded subject in the reset password mail

[anonymous]

The subject of the mail which will be sent after a user wants to reset his password should be customizeable as well in the appropriate template. See django-registration (activation_email.txt, activation_email_subject.txt).

[Chris Beaven]

This shouldn't be hardcoded (the actual solution, be it the proposed solution of separate template for the subject or alternatively just an argument in the view & form is up for debate).

[Austin Gabel]

I believe using a template for the subject is the correct way to go here. An argument would have to be something like 'subject=None' which seems confusing to me since there is a default subject line.

[Chris Beaven]

I'd suggest bringing it up in the django-dev group. Not sure we have a precedent set for this.

[Austin Gabel]

Attached the wrong patch before. I will be bringing up this patch to django-dev shortly.

[jkocherhans]

1.2 is feature frozen. Removing from the 1.2 milestone.

[Eric Holscher]

This seems sane to me. I don't know if a template, or a passed in string is the correct answer, but I think the fact that it shouldn't be hard coded is pretty clear. Going to change this back to accepted for now.

For this to get into trunk though, it will require docs & tests though.

[Jannis Leidel]

Yes, templates are the way to go here. Please use *.txt file extensions for them though, since the emails are clearly not HTML.

[Claude Paroz]

Updated patch containing a test

[Claude Paroz]

Here are some progress on this ticket (updated patch with test).
About the .txt extension for the template, I fear that the standard makemessages will not parse it for extracting the translatable content.

For docs, it appears that the registration forms API is not detailed in the documentation (​http://docs.djangoproject.com/en/1.2/topics/auth/#module-django.contrib.auth.forms). However, this raises the fact that the password_reset view might also receive a subject_template_name parameter. Is this wanted?

[Ramiro Morales]

Claude patch plus update of makmessages command and reset_password() view

[Jannis Leidel]

In [16437]:

Added '.txt' to list of file extensions that the makemessages management command automatically scans. Refs #12202.

[Jannis Leidel]

In [16438]:

Fixed #12202 -- Removed hardcoded password reset subject and added a subject_template_name parameter to the password_reset view. Thanks, Ramiro Morales, Claude Paroz and agabel.