urlizetrunc not taking into account last ')' of a link

[Stefan_Petrea]

Hi,

I'm using Django 1.1 , the release version.

The urlizetrunc filter is causing some problems , for example the following link
​http://en.wikipedia.org/wiki/Sibiu(Romania)

is rendered as <a href="​http://en.wikipedia.org/wiki/Sibiu%28Romania" rel="nofollow">​http://en.wikipedia.org/wik...</a>)
(please notice the trailing ')' )
This is not correct , it should take the ')' inside the link.

(As a work-around I'm adding # to my links, which seems to work).

Best regards,

Stefan

[Tom Mortimer-Jones]

Joint tests for tickets #11911 and #12183

[Tom Mortimer-Jones]

Joint patch for tickets #11911 and #12183

[Tom Mortimer-Jones]

I have attached tests and a patch that fixes this bug as well as #12183.

[Graham King]

Split out just the part for this ticket. Added tests.

[Graham King]

This is still a problem in current SVN, and the patch fixes it.

I've updated the patch to apply cleanly, to be just for this ticket, and to have tests. All the unit tests pass.

[trez]

It seems than the real problem come from the definition of punctuation_re:

TRAILING_PUNCTUATION = ['.', ',', ')', '>', '\n', '>']

punctuation_re = re.compile('^(?P<lead>(?:%s)*)(?P<middle>.*?)(?P<trail>(?:%s)*)$' % \
    ('|'.join([re.escape(x) for x in LEADING_PUNCTUATION]),
    '|'.join([re.escape(x) for x in TRAILING_PUNCTUATION])))

The ')' character is not interpreted as a part of the url but as an enclosing character.
The patch provided solve the parenthesis problem but do not solve other cases for other unreserved characters in the TRAILING_PUNCTUATION list.

Valid character accoding to RFC 1738 named as extra are "!" | "*" | "'" | "(" | ")" | ","

For example: ​http://en.wikipedia.org/wiki/Sibiu(Romania). which is the valid (notice the dot at the end of the url)

To completely solve this problem, I think an in-depth rewrite of the punctation_re should be done which should be able to distinguish between
​http://en.wikipedia.org/wiki/Sibiu(Romania) and (​http://en.wikipedia.org/wiki/Sibiu(Romania))

A design decision is needed.

[Graham King]

Could you provide an example of a live url where this is a problem, with characters other than parenthesis?

[Jacob]

Milestone 1.4 deleted

[Aymeric Augustin]

In [17362]:

Fixed #11911 -- Made the urlize filter smarter with closing punctuation.