Opened 15 years ago
Closed 14 years ago
#11882 closed (fixed)
Documentation missing for django.contrib.admin.ModelAdmin.formfield_for_manytomany
| Reported by: | Nils L | Owned by: | anonymous |
|---|---|---|---|
| Component: | Documentation | Version: | 1.1 |
| Severity: | Keywords: | formfield_for_manytomany, admin | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The documentation only describes the formfield_for_foreignkey method, but not the formfield_for_manytomany method of ModelAdmin.
See en/dev/ref/contrib/admin/. It would be good with some mention of the formfield_for_manytomany method there.
Attachments (3)
Change History (9)
comment:1 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
by , 15 years ago
| Attachment: | 11822.diff added |
|---|
comment:2 by , 15 years ago
| Has patch: | set |
|---|
by , 15 years ago
| Attachment: | 11882.diff added |
|---|
comment:3 by , 15 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
by , 15 years ago
| Attachment: | formfield_for_docs.diff added |
|---|
Updated documentation to fix buggy example code
comment:4 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I found a "bug" in the example code for both formfield_for_foreignkey and formfield_for_manytomany -- see updated patch. Best to let the super method handle the formfield rather than intercepting it, otherwise filter_horizontal etc won't be able to be applied upstream, causing issues such as this
comment:5 by , 15 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Hey, I didn't select "closed" or "fixed"... must have been preselected
comment:6 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.
small edits to existing patch