Unable to have label tags without a "for" attribute in form widgets

[Denis Martinez <deuns.martinez@…>]

In some cases I want to use a form widget without an input, such as pure javascript or iframe
(recaptcha_django in my case).

form.as_p() generates a label tag with an unmatched id: <label for="id_recaptcha"> .

This makes my page invalid in HTML5.

I tried to override id_for_label like this in my widget's code:

    def id_for_label(self, id_):
        return None

which gives <label for="None"> .

Anyway, I believe that this case should be treated adequately, because the docstring
states that id_for_label can return None values.

[Denis Martinez <deuns.martinez@…>]

handle None values from id_for_label

[DenisMartinez]

This patch has been accepted since Django 1.0, so can it be included mainline ?

I don't want to have to apply this on every release.

[Alex Gaynor]

The patch is clearly missing tests, which are not optional.

[DenisMartinez]

Same patch applied to svn r13303, including tests

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Sergey Kolosov]

Pull request: ​https://github.com/django/django/pull/1179

I had to reject tests from the patch above (those were doctests, and those tested a complete form rather than just a label tag).

[Sasha Romijn]

Looks fine to me. Tests work. I'd like to see it implemented slightly simpler, but because we also don't want a dangling for="" in the code when there is no ID, I think this is as clean as it gets.

[Claude Paroz]

In be0bab1bb8da80402248cd1fa22fd4cc09b34fe7:

Fixed #11725 -- Made possible to create widget label tag without "for"

Thanks Denis Martinez for the report and initial patch, and
Sergey Kolosov for bringing the patch up to date.