Opened 15 years ago

Closed 14 years ago

Last modified 12 years ago

#11700 closed Uncategorized (fixed)

actions and list_editables in popups problematic

Reported by: sehmaschine@… Owned by: Simon Meers
Component: contrib.admin Version: dev
Severity: Normal Keywords: design_ux, sprintdec2010
Cc: Gonzalo Saavedra, sehmaschine@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

IMHO, actions should not be visible in popups. list_editable should also not work, because

  • in popups, one is able to select and add elements. changing an element is not possible. so, why is it possible to change elements on the level of a change-list?
  • moreover, delete_selected_confirmation doesn´t handle popups correctly.

Attachments (1)

11700.diff​ (4.3 KB ) - added by Simon Meers 14 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by Russell Keith-Magee, 15 years ago

Resolution: → invalid
Status: new → closed

If you have a design opinion, take it up on django-dev. As fair warning - abstract suggestions aren't going to get much traction unless you're willing to back them up with code.

comment:2 by Russell Keith-Magee, 15 years ago

Resolution: invalid
Status: closed → reopened
Triage Stage: Unreviewed → Design decision needed
Version: 1.1

In light of the recent discussions regarding the state of Django's design, I'm reopening and marking this DDN.

comment:3 by Russell Keith-Magee, 15 years ago

Keywords: design_ux added

comment:4 by mrts, 15 years ago

A tip for those who need to hide actions in popups:

class FooAdmin(admin.ModelAdmin):
    def get_actions(self, request):
        actions = super(ShowInListAdmin, self).get_actions(request)
        if request.REQUEST.has_key('pop'): # hide actions in popups
            actions.clear()
        return actions

comment:5 by Simon Meers, 14 years ago

Has patch: set
milestone: → 1.3
Owner: changed from nobody to Simon Meers
Status: reopened → new
Triage Stage: Design decision needed → Accepted
Version: → SVN

​http://groups.google.com/group/django-developers/browse_thread/thread/c8da7710647dc979

by Simon Meers, 14 years ago

Attachment: 11700.diff​ added

comment:6 by Gonzalo Saavedra, 14 years ago

Cc: Gonzalo Saavedra added

comment:7 by Simon Meers, 14 years ago

Keywords: sprint_dec_2010 added

comment:8 by Simon Meers, 14 years ago

Keywords: sprintdec2010 added; sprint_dec_2010 removed

comment:9 by Brodie Rao, 14 years ago

Triage Stage: Accepted → Ready for checkin

comment:10 by anonymous, 14 years ago

Cc: sehmaschine@… added

comment:11 by Jannis Leidel, 14 years ago

Resolution: → fixed
Status: new → closed

(In [15129]) Fixed #11700 -- Stopped admin actions and list_editable fields to show up in popups. Thanks to Simon Meers for the initial patch.

comment:12 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

comment:13 by anonymous, 12 years ago

Easy pickings: unset
Severity: → Normal
Type: → Uncategorized
UI/UX: unset
Note: See TracTickets for help on using tickets.
Back to Top