Missing parameter in cursor method (BaseDatabaseWrapper)

[Maximiliano Robaina]

In db/backends/init.py the cursor method of BaseDatabaseWrapper class, has a missed parameter (line 81).

Original code (django 1.1 beta1 - trunk)

def cursor(self):
        from django.conf import settings
        cursor = self._cursor()  #<--here
        if settings.DEBUG:
            return self.make_debug_cursor(cursor)
        return cursor

In line 81:

cursor = self._cursor()

Should be:

cursor = self._cursor(setting)

When I run syncdb, a missing parameter error is raised.

[Alex Gaynor]

None of the backends in django have an _cursor method that takes any parameters, external backends will need to be updated to respsect the new type signature.

[Maximiliano Robaina]

In previous versión (1.0 final), line 81 has:

cursor = self._cursor(settings)

This change in new 1.1 beta-1. It's correct?

[Alex Gaynor]

Yes. See r10026

[Jacob]

Milestone 1.1 deleted