django.contrib.markup.tests.Templates test_textile fails with python textile 2.1.3 and Django 1.0.2 final

[ntoll]

Getting the following message:

======================================================================
FAIL: test_textile (django.contrib.markup.tests.Templates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Library/Python/2.5/site-packages/django/contrib/markup/tests.py", line 27, in test_textile
    <p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>""")
AssertionError: u'<p>Paragraph 1</p>\n\n\t<p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>' != '<p>Paragraph 1</p>\n\n<p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>'

----------------------------------------------------------------------

Looks like there is an extra "\t" in there before the "Paragraph 2" <p> element.

[Alex Gaynor]

Please use preview.

[Arthur Koziel]

I can confirm that. There needs to be an extra '\t'.

[Karen Tracey]

Just adding a '\t' will cause the test to fail on older versions of textile (the test currently works for me, for example, with textile 2.0.10 which is what is installed on my ubuntu machine, but would break if the test was expecting the extra '\t'). We don't want to just move the problem, we want to fix it.

[Arthur Koziel]

I've only tried versions from 2.1.0 to 2.1.3. The 2.0.x versions don't have the '\t'.

[Bruno Renié]

Wouldn't it be safe just to change

self.assertEqual(rendered, """<p>Paragraph 1</p> # etc

to

self.assertEqual(rendered.replace('\t', ''), """<p>Paragraph 1</p> # etc

We don't really care about tabulations (only the markup is important), and it
prevents the test to fail if textile changes its behavior again in the future.

[Bruno Renié]

Patch without version check, just removes tabs from the rendered text

[Jacob]

(In [13360]) Fixed #10843: the textile tests now pass against the latest textile library.

[Tom Aratyn]

Occurred again with django 1.2.1 and textile 2.1.4.

$python manage.py test

yields:

======================================================================
FAIL: test_textile (django.contrib.markup.tests.Templates)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/Django-1.2.1-py2.6.egg/django/contrib/markup/tests.py", line 27, in test_textile
    <p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>""")
AssertionError: u'<p>Paragraph 1</p>\n\n\t<p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>' != '<p>Paragraph 1\
</p>\n\n<p>Paragraph 2 with &#8220;quotes&#8221; and <code>code</code></p>'

----------------------------------------------------------------------

Removing the textile egg resolves the issue (since I don't need textile for anything).

[Chris Beaven]

Increasing severity, working tests are paramount.

[patchhammer]

10843.patch fails to apply cleanly on to trunk

[Luke Plant]

1.2.1 was released *before* the fix for this, and in 1.2.2 and on 1.3.X and trunk, the test passes (with textile==2.1.4). I have no idea why the bug has been reopened.