FormWizard should not output raw HTML for previous_fields

[Matthew Flanagan <mattimustang@…>]

When using a FormWizard to generate forms it populates a context variable called previous_fields which contains raw HTML hidden fields for the previous step values and security hashes. This does not play well when you are trying to use the FormWizard in other types markup.

My use case is that I'm using extjs for my application front-end and form presentation (though I could be using something else like XForms for example). I have a templatetag that spits out the appropriate extjs form widget when given a bound field. This fails for the FormWizard previous_fields because it is raw HTML.

The patch attached turns previous_fields into a list of bound field objects that can be iterated over to output the same raw HTML as before or give you more control over the output.

[Matthew Flanagan <mattimustang@…>]

patch for class and docs

[Matthew Flanagan <mattimustang@…>]

See here for a installable module if you don't want to wait until Django 1.2 arrives.

​http://wadofstuff.blogspot.com/2009/07/improved-django-formwizard.html

[Jacob]

This doesn't appear to be backwards compatible, which it needs to be if it's to go into 1.2.

[James Bennett]

If it's not backwards-compatible it can't land in 1.2; luckily, you get another release cycle to get it into shape :)

[Łukasz Rekucki]

It's 1.3 now and apart from not being backwards compatible, looks good to me. This also helps writing tests, because you don't have to parse the raw HTML to get the security_hash for the next step.

[Luke Plant]

It's not ready for checkin if it's not backwards compatible, as Jacob said before. This needs a much better patch - for example, a new method that provides the new required format. With docs and tests, of course.

[steph]

Patch with tests and docs.

[steph]

.. just added a better patch including tests for the old previous_fields and the new previous_fields_list.

[Luke Plant]

There are backwards compatibility issues with changing the signature of FormWizard.render_template. It is a method that subclasses can override, therefore changes to it must be done with keyword arguments, and any time it is called from the FormWizard class we must check that the method accepts the keyword argument we want to pass (use inspect.getargspec).

Thanks.

[steph]

Better patch with argument inspection

[patchhammer]

trac-10557.2.diff fails to apply cleanly on to trunk

[Jannis Leidel]

Superseded by #9200.

[Jacob]

Milestone 1.3 deleted