provide **kwargs argument to GenericInlineModelAdmin.get_formset

[lakin@…]

InlineModelAdmin.get_formset provides kwargs to override defaults:

    def get_formset(self, request, obj=None, **kwargs):
        """Returns a BaseInlineFormSet class for use in admin add/change views."""
        if self.declared_fieldsets:
            fields = flatten_fieldsets(self.declared_fieldsets)
        else:
            fields = None
        if self.exclude is None:
            exclude = []
        else:
            exclude = self.exclude
        defaults = {
            "form": self.form,
            "formset": self.formset,
            "fk_name": self.fk_name,
            "fields": fields,
            "exclude": exclude + kwargs.get("exclude", []),
            "formfield_callback": self.formfield_for_dbfield,
            "extra": self.extra,
            "max_num": self.max_num,
        }
        defaults.update(kwargs)
        return inlineformset_factory(self.parent_model, self.model, **defaults)

Shouldn't we do the same for GenericInlineModelAdmin.get_formset ?

Potential Patch:

    def get_formset(self, request, obj=None, **kwargs):
        if self.declared_fieldsets:
            fields = flatten_fieldsets(self.declared_fieldsets)
        else:
            fields = None
        defaults = {
            "ct_field": self.ct_field,
            "fk_field": self.ct_fk_field,
            "form": self.form,
            "formfield_callback": self.formfield_for_dbfield,
            "formset": self.formset,
            "extra": self.extra,
            "can_delete": True,
            "can_order": False,
            "fields": fields,
        }
        defaults.update(kwargs)
        return generic_inlineformset_factory(self.model, **defaults)

I chose the "Contrib Apps" component because there is no "contrib.contenttypes".

[Brian Rosner]

I was just thinking about this today as I was going through this code.

[anonymous]

If you're having a go at fixing this one, you should consider fixing #9122 at the same time, it's kinda related in the "Make the GenericInlineModelAdmin more like the InlineModelAdmin" category. :)

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Julien Phalip]

Thanks a lot for the patch. It is a simple change but tests are still needed. Passing a couple of kwargs and making sure that they override the defaults would be enough.

[Preston Timmons]

Added tests. Patched against r16231.

[Julien Phalip]

Excellent, thanks a lot.

[Jannis Leidel]

In [16419]:

Fixed #9588 -- Allow passing kwargs to GenericInlineModelAdmin.get_formset just like the InlineModelAdmin. Thanks, prestontimmons.