Opened 16 years ago
Closed 14 years ago
#9568 closed (fixed)
admin/login.html should contain empty nav-global block
Reported by: | Wayne K. Werner | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | 1.0 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The admin/login.html template includes an empty 'breadcrumbs' block, to make sure that any breadcrumbs are suppressed. As the login form is presented in a small frame, much like a popup where breadcrumbs are also supressed, this seems reasonable.
However, while nav-global blocks are suppressed in popups (along with the entire header), they do however appear on the login dialog. This causes the login page to look strange, at the least, for anyone employing the nav-global block in a custom admin/base_site.html or admin/base.html.
Inserting {% block nav-global %}{% endblock %} near the empty breadcrumbs block would eliminate this eyesore.
I am doing so in a custom admin/login.html currently to deal with this, but I think this is probably an oversight in the 'real' admin/login.html. Understandable in that the nav-global block is probably rarely used.
Attachments (1)
Change History (6)
by , 16 years ago
Attachment: | login_template.diff added |
---|
comment:1 by , 16 years ago
Component: | Uncategorized → django.contrib.admin |
---|---|
Has patch: | set |
comment:2 by , 16 years ago
milestone: | → 1.1 |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 16 years ago
milestone: | 1.1 → 1.2 |
---|
comment:4 by , 15 years ago
milestone: | 1.2 |
---|
comment:5 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
1.2 is feature-frozen, moving this feature request off the milestone.