Opened 16 years ago

Closed 15 years ago

#9223 closed (fixed)

Declarative widgets for ModelForm

Reported by: Ivan Sagalaev Owned by: nobody
Component: Forms Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Implementation of widgets attribute of inner Meta class of ModelForm. The whole (but short!) discussion is here: ​http://groups.google.com/group/django-developers/browse_frm/thread/f879f383870b92c1

Attachments (4)

9223.diff​ (5.8 KB ) - added by Ivan Sagalaev 16 years ago.
Patch with test and docs
9223.2.diff​ (5.6 KB ) - added by Ivan Sagalaev 16 years ago.
Patch correcting the bug with shared dict
9223.3.diff​ (5.6 KB ) - added by Ivan Sagalaev 16 years ago.
Patch updated to current trunk
9223.4.diff​ (5.6 KB ) - added by Ivan Sagalaev 15 years ago.
Patch updated to current trunk

Download all attachments as: .zip

Change History (10)

by Ivan Sagalaev, 16 years ago

Attachment: 9223.diff​ added

Patch with test and docs

comment:1 by Ivan Sagalaev, 16 years ago

Has patch: set

comment:2 by Chris Beaven, 16 years ago

Bug: You're sharing the kwargs dict, so it'll get applied to all following fields.

by Ivan Sagalaev, 16 years ago

Attachment: 9223.2.diff​ added

Patch correcting the bug with shared dict

comment:3 by Ivan Sagalaev, 16 years ago

Good catch, thanks! I've fixed the bug and added a test specifically for this issue.

comment:4 by Jacob, 16 years ago

Triage Stage: Unreviewed → Accepted

by Ivan Sagalaev, 16 years ago

Attachment: 9223.3.diff​ added

Patch updated to current trunk

comment:5 by Simon Litchfield, 15 years ago

Triage Stage: Accepted → Ready for checkin

This patch isn't present in rev 11440.

by Ivan Sagalaev, 15 years ago

Attachment: 9223.4.diff​ added

Patch updated to current trunk

comment:6 by Adrian Holovaty, 15 years ago

Resolution: → fixed
Status: new → closed

(In [12194]) Fixed #9223 -- Added support for declarative widgets to ModelForm. I declare thanks to isagalaev.

Note: See TracTickets for help on using tickets.
Back to Top