Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#8959 closed (fixed)

Remove calls to escape in new comments framework templates

Reported by: Jarek Zgoda Owned by: Adrian Holovaty
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As autoescaping is in place with current Django, escaping values in templates is not necessary. Attached patch fixes this.

Attachments (1)

contrib-comments-escaping.diff (5.2 KB ) - added by Jarek Zgoda 16 years ago.
Removing calls to escape in templates

Download all attachments as: .zip

Change History (6)

by Jarek Zgoda, 16 years ago

Removing calls to escape in templates

comment:1 by Thejaswi Puthraya, 16 years ago

Triage Stage: UnreviewedDesign decision needed

True, but I don't see anything wrong with keeping it on. It's better to be safe than never. Marking it DDN for some core-devs to comment on this.

comment:2 by Jarek Zgoda, 16 years ago

Sure, nothing wrong. It's just for consistency.

comment:3 by Adrian Holovaty, 16 years ago

Owner: changed from nobody to Adrian Holovaty
Status: newassigned
Triage Stage: Design decision neededAccepted

It's worth removing those unnecessary "escape" filters, given that they're redundant and cause a slight be of extra overhead. I will review and check in the patch.

comment:4 by Adrian Holovaty, 16 years ago

Resolution: fixed
Status: assignedclosed

(In [9000]) Fixed #8959 -- Removed redundant calls to the 'escape' template filter in the django.contrib.comments templates. Thanks, zgoda

comment:5 by (none), 16 years ago

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top