HTML markup appearing in title of doc page

[gkelly]

The page at ​http://docs.djangoproject.com/en/dev/ref/models/options/ has HTML markup appearing in the title for the page. I haven't seen this with other pages, but it's possible this isn't the only affected URL.

[gkelly]

This page is also affected: ​http://docs.djangoproject.com/en/dev/ref/files/file/

[gkelly]

Fixes title, but removes other markup

[gkelly]

Please ignore patch, a better solution would be to use a template filter to strip the HTML from the title, such as

Index: djangodocs/templates/docs/doc.html
===================================================================
--- djangodocs/templates/docs/doc.html	(revision 8965)
+++ djangodocs/templates/docs/doc.html	(working copy)
@@ -1,6 +1,6 @@
 {% extends "base_docs.html" %}
 
-{% block title %}{{ doc.title }} | Django Documentation{% endblock %}
+{% block title %}{{ doc.title|striptags }} | Django Documentation{% endblock %}
 
 {% block extrahead %}
   {{ block.super }}

[arien]

Changing component; locally generated HTML (make html) doesn't have this problem.

[Carl Meyer]

#9162 and #9160 were duplicates.

​http://docs.djangoproject.com/en/dev/internals/release-process/ is also affected.

[Julien Phalip]

​http://docs.djangoproject.com/en/dev/ref/contrib/comments/ also suffers from this strange disease :)

[Chris Beaven]

See also for another semi-related problem: #9517 (titles show up escaped in Browse section of the sidebar)

[Karen Tracey]

#9584 report his also for ​http://docs.djangoproject.com/en/dev/topics/cache/

[Ramiro Morales]

#9647 was also a duplicate, and it suggested:

Maybe a |safe filter is needed to be appended to the title tag to allow these characters to be unescaped? 

[Karen Tracey]

#10495 reported this again and also suggested a striptags filter on the title tag.

[Karen Tracey]

Meant to close the other one, not this one.

[anonymous]

This is still occurring, nearly 11 months after first being opened :)

[Chris Beaven]

#11839 suggests striptags filter too, and has a patch. Modifying documentation to work around the current problem isn't the solution, so I'm marking the patch here as "needs improvement".

[James Bennett]

(In [11598]) Fixed #8885 and its many duplicates (hopefully) by stripping HTML (which implies mark_safe) to titles of documentation pages.

[Karen Tracey]

Replying to ubernostrum:

(In [11598]) Fixed #8885 and its many duplicates (hopefully) by stripping HTML (which implies mark_safe) to titles of documentation pages.

striptags has is_safe=True but that won't explicitly mark the output as safe, it will just preserve the safe status of input. We don't mark the title as safe, so it is still being escaped, which means titles with smart quotes, such as:

​http://docs.djangoproject.com/en/dev/ref/contrib/sites/
​http://docs.djangoproject.com/en/dev/ref/contrib/comments/
​http://docs.djangoproject.com/en/dev/internals/release-process/
​http://docs.djangoproject.com/en/dev/topics/cache/

are still looking a bit odd. Could we also just explicitly run doc.title through the safe filter?