Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#7946 closed (fixed)

Object history should reuse existing date formats, instead of implementing itself

Reported by: Marc Garcia Owned by: nobody
Component: Internationalization Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django has some date formats in trans_real.py that can be defined in translations, and used anywhere. Different formats exists such as DATE_FORMAT, DATETIME_FORMAT, TIME_FORMAT...

Object history template is using another format, that actually is (or should be) the same as DATETIME_FORMAT, called DATE_WITH_TIME_FULL.

I think that if the format is the same, it should be defined once, or if it isn't the same, it should be added to trans_real.py to allow usage in user's code.

Attachments (1)

7946.diff​ (757 bytes ) - added by Marc Garcia 16 years ago.
patch for using existing format

Download all attachments as: .zip

Change History (6)

by Marc Garcia, 16 years ago

Attachment: 7946.diff​ added

patch for using existing format

comment:1 by Jeff Anderson, 16 years ago

milestone: → 1.0
Triage Stage: Unreviewed → Design decision needed

This makes sense to me, but I don't know if there was a good reason for doing it this way in the first place.

comment:2 by ebruning, 16 years ago

Has patch: set

comment:3 by Jacob, 16 years ago

Triage Stage: Design decision needed → Ready for checkin

comment:4 by Russell Keith-Magee, 16 years ago

Resolution: → fixed
Status: new → closed

(In [8485]) Fixed #7946: Modified object history template to use a common date format. Thanks to Marc Garcia for the report and patch.

comment:5 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top